Skip to content

Add diagnostics to ok tests#148

Merged
mblayman merged 1 commit into
python-tap:mainfrom
codambro:main
Jan 26, 2025
Merged

Add diagnostics to ok tests#148
mblayman merged 1 commit into
python-tap:mainfrom
codambro:main

Conversation

@codambro

@codambro codambro commented Jan 25, 2025

Copy link
Copy Markdown
Contributor

Support adding diagnostic lines under an ok test

To accept your contribution, please ensure that the checklist below is complete.

  • Is your name/identity in the AUTHORS file?
  • Does the code change (if the PR contains code) have 100% test coverage?
  • Is CI passing all quality and testing checks?

@mblayman

Copy link
Copy Markdown
Member

Hi @codambro, thanks for the contribution! I saw your PR and had to update tappy to prepare it for another release to include your change. Unfortunately, given the changes I made to file locations, that created conflicts here. Given that you change is fairly small, it may just be easier to start another PR and reapply your changes to the latest main. Whichever you decide, I'd be happy to accept your change once it's ready to merge.

@codambro codambro reopened this Jan 26, 2025

@mblayman mblayman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@mblayman mblayman merged commit 89762f4 into python-tap:main Jan 26, 2025
@mblayman

Copy link
Copy Markdown
Member

Released as part of https://pypi.org/project/tap.py/3.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants